Getting version from Pono#1157
Merged
Merged
Conversation
The flag "--version" is now supported in Pono (see stanford-centaur/pono#372).
Some tools (e.g., Pono) returns non-zero exit code when executed with the flag "--version". A new option is introduced in _version_from_tool() to specify the expected exit code. This change is backward compatible.
PhilippWendler
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
./pono --versionhas non-zero exit code,a new option
expected_exitcodeis introduced in_version_from_tool().If such a change is not desirable,
I could write a custom function for Pono,
instead of reusing the existing one.