Support value-dependent hyperlinks in table generator #1246
+102
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement support for ${value} placeholder in the href attribute of
table columns. This allows dynamic hyperlinks that reference the content
of the current table cell.
- Added support for ${value} substitution in _create_link.
- Updated prepare_value and clean_up_results to pass cell values.
- Maintained backward compatibility for static strings and other variables.
- Added unit test to verify substitution logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the ${value} placeholder in the
hrefattribute of table columns in BenchExec. This allows users to create dynamic hyperlinks that reference the content of the current table cell.Changes
_create_linkinbenchexec/tablegenerator/htmltable.pyto support ${value} substitution.prepare_valueandclean_up_resultsto the link generator.benchexec/tablegenerator/test_href_substitution.pyto verify the substitution logic.Examples
Users can now use the following in their table definitions:
<column title="witness" href="links/${value}">wit</column>This will replace ${value} with the raw value of the cell for each row.
Fixes #1217