Skip to content

Convert multiple components from JavaScript to TypeScript#1256

Merged
PhilippWendler merged 56 commits into
typescript-migration/typescript-full-migrationfrom
typescript-migration/migration/components-folder-part1
Feb 27, 2026
Merged

Convert multiple components from JavaScript to TypeScript#1256
PhilippWendler merged 56 commits into
typescript-migration/typescript-full-migrationfrom
typescript-migration/migration/components-folder-part1

Conversation

@Simon1375
Copy link
Copy Markdown
Contributor


Description

This pull request primarily focuses on converting several React components from JavaScript to TypeScript. Changes include renaming files to .tsx, making necessary TypeScript-specific adjustments for compatibility, and refining typings throughout the affected components.

Modified Components:

  • LinkOverlay
  • SelectColumn
  • StatisticsTable
  • Summary
  • TableComponents
  • TaskDefinitionViewer
  • Info
  • FilterInfoButton

Changes:

  • Renamed component files from .js to .tsx.
  • Updated and refined typings.
  • Ensured all converted components compile correctly in TypeScript.
  • Refactored code in some components for improved clarity and maintainability.

Copy link
Copy Markdown
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This time I only found minor stuff.

Comment thread benchexec/tablegenerator/react-table/src/components/Info.tsx Outdated
Comment thread benchexec/tablegenerator/react-table/src/components/Info.tsx
Comment thread benchexec/tablegenerator/react-table/src/components/TaskDefinitionViewer.tsx Outdated
Comment thread benchexec/tablegenerator/react-table/src/components/TaskDefinitionViewer.tsx Outdated
@PhilippWendler PhilippWendler merged commit 332cb2f into typescript-migration/typescript-full-migration Feb 27, 2026
15 checks passed
@PhilippWendler PhilippWendler deleted the typescript-migration/migration/components-folder-part1 branch February 27, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants