-
Notifications
You must be signed in to change notification settings - Fork 32
Feature/api turntaking #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #290 +/- ##
===========================================
+ Coverage 32.29% 77.37% +45.08%
===========================================
Files 50 65 +15
Lines 2793 3912 +1119
===========================================
+ Hits 902 3027 +2125
+ Misses 1891 885 -1006
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so the websocket enables turn-taking. qq, how does the connection with redis agent work here?
is the redisagent still on the tac side? (maybe share the tac repo with me as well?)
We have the NPCs stored on Sotopia side (created/deleted using FastAPI calls from TAC). The main agent interacts with these NPCs, with the message broker still on TAC side. |
cfc3b63
to
6c7de04
Compare
d8b4ea5
to
2ac8912
Compare
a81417e
to
97818bf
Compare
5f214d2
to
5bc7714
Compare
8b50805
to
3643e68
Compare
3943012
to
be6593a
Compare
465c2bf
to
07de04f
Compare
📑 Description
This PR adds WebSocket support for turnwise interaction in Sotopia. The implementation enables real-time interaction between:
Unit tests have been added to ensure correctness, and the WebSocket implementation supports smooth turnwise communication.
✅ Checks
type/descript
(e.g.feature/add-llm-agents
)ℹ Additional Information
No breaking changes. The WebSocket implementation integrates seamlessly with existing logic. Let me know if any modifications or additional tests are needed.