Feature/new handling message #302
Conversation
| status: Literal["Started", "Error", "Completed"] | ||
|
|
||
|
|
||
| class BaseEpisodeLog(BaseModel): |
There was a problem hiding this comment.
why this whole new class but not just inherit from the original BaseEpisodeLog?
There was a problem hiding this comment.
I was under the assumption that the code in experimental would replace the code in the current logs.py. So I made changes to the BaseEpisodeLog class
| len(self.rewards) == agent_number | ||
| ), f"Number of agents in rewards {len(self.rewards)} and agents {agent_number} do not match" | ||
| return self | ||
|
|
||
| def render_for_humans(self) -> tuple[list[AgentProfile], list[str]]: |
There was a problem hiding this comment.
Are we using the function anywhere?
There was a problem hiding this comment.
This was present in the previous code so I kept it in the new code as well
sotopia/experimental/agents/logs.py
Outdated
| "groups": self.groups, | ||
| } | ||
|
|
||
| def add_message( |
There was a problem hiding this comment.
Are we using this function anywhere?
There was a problem hiding this comment.
I have removed the function.
| @@ -2,7 +2,7 @@ | |||
| from redis_om.model.model import Field | |||
| from pydantic import create_model, BaseModel, AfterValidator | |||
| from typing import Type, Callable, Tuple, Annotated, Union, cast, Any | |||
| from sotopia.envs import SotopiaDimensions | |||
| from sotopia.envs.evaluators import SotopiaDimensions | |||
There was a problem hiding this comment.
I was getting errors in my tests where it was not able to import SotopiaDimensions
| ) | ||
|
|
||
| # Create a filtered copy of the epilog | ||
| filtered_epilog = self.filter_epilog_for_recipient( |
There was a problem hiding this comment.
remove this filter thing
…opia-lab/sotopia into feature/new_handling_message
…opia-lab/sotopia into feature/new_handling_message
Closes #
📑 Description
✅ Checks
type/descript(e.g.feature/add-llm-agents)ℹ Additional Information