Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:

permissions:
id-token: write
contents: write
packages: read

jobs:
release:
Expand All @@ -28,7 +30,14 @@ jobs:
run: npm ci
- name: Build
run: make build
# Authenticate as sc-governed-write so the push bypasses the security gate.
# See https://eng-doc.soundcloud.org/security/security-gate/bypass-allowlist/
- name: Authenticate for governed default-branch push
id: sc-governed-write
uses: soundcloud/security-tooling/.github/actions/sc-governed-write-auth@2e4086b2fe93e68d074a8037d18f55a3f0ea78ce
with:
sc-governed-write-app-private-key: ${{ secrets.SC_GOVERNED_WRITE_APP_PRIVATE_KEY }}
- name: Release
env:
GH_TOKEN: ${{ secrets.CI_TOKEN }}
GH_TOKEN: ${{ steps.sc-governed-write.outputs.token }}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something we need to check is that the sc-governed-write token has the necessary permissions. Could someone please confirm?

Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added sc-goverened-write to this repo's branch protection rule's bypass list. However, it would be preferable to migrate this rule to a ruleset (GH's new preferred way of protecting branches).

run: npm run semantic-release
Loading