Build and publish only LTS scala 3 #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmtaylor
approved these changes
Feb 12, 2025
| @@ -2,8 +2,7 @@ import sbt.CrossVersion | |||
|
|
|||
| lazy val scala212 = "2.12.18" | |||
| lazy val scala213 = "2.13.14" | |||
| lazy val scala3LTS = "3.3.4" | |||
| lazy val scala3 = "3.6.3" | |||
| lazy val scala3LTS = "3.3.5" | |||
There was a problem hiding this comment.
I'm not too familiar with scala3 release process / backwards compat. When will we know. to update this?
There was a problem hiding this comment.
so they backported random things into 3.3.4 which i need to be able to ignore specific warnings from src dirs.. its hard to say basically.. 3.3.5 only came out in late jan
| ) | ||
| case _ => Seq.empty | ||
| } | ||
| }, | ||
| // compile protobuf messages for unit tests | ||
| Project.inConfig(Test)(sbtprotoc.ProtocPlugin.protobufConfigSettings), | ||
| Test / scalacOptions += { | ||
| CrossVersion.partialVersion(scalaVersion.value) match { | ||
| case Some((3, minor)) if minor > 3 => "-experimental" |
There was a problem hiding this comment.
I wonder if we'll run into this when @scala-steward bumps the version of scalamock / scala 3 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declaring 3 scala minor versions always takes the latest when projects pull in the dependency. this causes issue as the TASTy reader is always looking at the latest binary (in this 3.6.3) so runtimes cause incompatibility errors. if developers wish to use 3.6.3, twinagle will still compile for them when its built with 3.3.x.
This also reduces some complexity in the tests configuration as we dont need to manage 2 versions of scalamock
also handles #451