fix(rune): address conductor migration nitpicks - #866
Open
martin-henz wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens #835, which was automatically closed (not merged) when its base branch
conductor-migrationwas deleted after being merged intomastervia #680. This branch cherry-picks the original commit from @11suixing11 unchanged, onto currentmaster.Summary
Addresses #827
Motivation
This PR follows #827, which came from checking which CSG conductor-migration review findings also apply to Rune. It is scoped to the four Rune items from that issue and intentionally does not address the separate duplicate-delivery or js-slang error-shape issues tracked in #823 and #825.
Concrete Cases
[undefined]intoBaseModulePluginbefore throwing Rune's own missing-channel error. Moving the guard beforesuper(...)keeps invalid channel state out of the base plugin.await plugin.initialise()twice re-ransuper.initialise()and re-pushed method and primitive-rune exports. The new guard wraps the full method so repeated initialisation leaves the export list stable.__loadRuneTab()previously usedtabs[0]. Looking upRUNE_TAB_NAMEkeeps the tab contract explicit if the host ever provides more than one tab.deserializeRune. Sharing it fromprotocol.tslets the bundle test the same serialization/deserialization path used by the tab.Testing (from original PR, re-verify on CI)
yarn workspace @sourceacademy/bundle-rune test(47 passed)yarn workspace @sourceacademy/bundle-rune tscyarn workspace @sourceacademy/bundle-rune lintyarn workspace @sourceacademy/tab-Rune test(3 passed in Chromium)yarn workspace @sourceacademy/tab-Rune tscOriginal author: @11suixing11