fix: keep rune and repeat bundles conductor-safe - #868
Open
martin-henz wants to merge 2 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens #837, which was automatically closed (not merged) when its base branch
conductor-migrationwas deleted after being merged intomastervia #680. This branch cherry-picks the original commits from @11suixing11 unchanged, onto currentmaster.Summary
Fixes #825
Testing (from original PR, re-verify on CI)
yarn workspace @sourceacademy/bundle-rune testyarn workspace @sourceacademy/bundle-repeat testyarn workspace @sourceacademy/bundle-rune tscyarn workspace @sourceacademy/bundle-repeat tscyarn workspace @sourceacademy/bundle-rune lintyarn workspace @sourceacademy/bundle-repeat lint(passes with existing IModuleExport warning)rg "js-slang|@sourceacademy/modules-lib/(errors|utilities)|assertNumberWithinRange|callWithoutMetadata|InvalidParameterTypeError|GeneralRuntimeError" build/bundles/rune.js build/bundles/repeat.js -n(no matches)Original author: @11suixing11