Skip to content

Bump @sourceacademy/conductor to 0.8.0 - #64

Merged
martin-henz merged 1 commit into
mainfrom
bump-conductor-0.8.0
Jul 25, 2026
Merged

Bump @sourceacademy/conductor to 0.8.0#64
martin-henz merged 1 commit into
mainfrom
bump-conductor-0.8.0

Conversation

@martin-henz

Copy link
Copy Markdown
Member

Summary

  • Bumps @sourceacademy/conductor from ^0.5.0 to ^0.8.0.
  • 0.8.0 includes conductor#53: hostLoadPlugin/requestLoadPlugin become async (Promise<void> instead of void), and the RPC procedure is renamed from the notification $requestLoadPlugin to the awaitable requestLoadPlugin.

Why no code changes

The only call site, src/runner/module-loader/src/index.ts's loadTab callback (this.__conductor.hostLoadPlugin(tabName)), is fire-and-forget and its return value is already discarded, so it compiles and behaves the same against the new Promise<void> return. eslint on that file is clean (no floating-promise rule configured in this repo).

Test plan

  • yarn eslint src/runner/module-loader/src/index.ts passes
  • yarn build / yarn test — currently broken on this machine's Node 20 (fs.glob requires Node 22+) independent of this change; verified via git stash that the same failures reproduce on unmodified main. Should be re-run in CI (Node 22+) before merge.

Draft — not merging yet.

🤖 Generated with Claude Code

PR source-academy/conductor#53 makes hostLoadPlugin/requestLoadPlugin
async (Promise<void> instead of void) and renames the RPC procedure
from the notification $requestLoadPlugin to the awaitable
requestLoadPlugin.

The only call site (runner/module-loader's loadTab callback) is
fire-and-forget and still compiles/behaves the same against the new
Promise<void> return; eslint passes on the file unchanged.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@changeset-bot

changeset-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 45dabf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@sourceacademy/web-stepper" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch

@martin-henz
martin-henz marked this pull request as ready for review July 25, 2026 04:57
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@martin-henz
martin-henz merged commit 14d2e8f into main Jul 25, 2026
2 checks passed
@martin-henz
martin-henz deleted the bump-conductor-0.8.0 branch July 25, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant