Bump @sourceacademy/conductor to 0.8.0 - #64
Merged
Conversation
PR source-academy/conductor#53 makes hostLoadPlugin/requestLoadPlugin async (Promise<void> instead of void) and renames the RPC procedure from the notification $requestLoadPlugin to the awaitable requestLoadPlugin. The only call site (runner/module-loader's loadTab callback) is fire-and-forget and still compiles/behaves the same against the new Promise<void> return; eslint passes on the file unchanged.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
martin-henz
marked this pull request as ready for review
July 25, 2026 04:57
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sourceacademy/conductorfrom^0.5.0to^0.8.0.0.8.0includes conductor#53:hostLoadPlugin/requestLoadPluginbecome async (Promise<void>instead ofvoid), and the RPC procedure is renamed from the notification$requestLoadPluginto the awaitablerequestLoadPlugin.Why no code changes
The only call site,
src/runner/module-loader/src/index.ts'sloadTabcallback (this.__conductor.hostLoadPlugin(tabName)), is fire-and-forget and its return value is already discarded, so it compiles and behaves the same against the newPromise<void>return.eslinton that file is clean (no floating-promise rule configured in this repo).Test plan
yarn eslint src/runner/module-loader/src/index.tspassesyarn build/yarn test— currently broken on this machine's Node 20 (fs.globrequires Node 22+) independent of this change; verified viagit stashthat the same failures reproduce on unmodifiedmain. Should be re-run in CI (Node 22+) before merge.Draft — not merging yet.
🤖 Generated with Claude Code