Fallback mechanism for the woff/woff2 dependencies #403
Conversation
…esource link to README (source-foundry#383)
If sfnt2woff-zopfli and woff2_compress binaries are not found in the installation directory targeted when the scripts are called with --install-dependencies, then look if the binaries are installed system-wide (i.e., in the $PATH). Fixes source-foundry#395.
There was a problem hiding this comment.
Version pinning issue applies here too. Should we be trying to pin these to specific versions or do you want the flexibility to build with whatever version you have available to you and test for unintended changes in the web fonts yourself? Upstream we will be using the approach defined by the build-with-dependencies target.
| INSTALLFLAG=1 | ||
| else | ||
| SFNTWOFF_BIN="sfnt2woff-zopfli" | ||
| echo "sfnt2woff-zopfli executable identified" |
There was a problem hiding this comment.
Possible to modify the stdout for users to explicitly indicate that they are building with the system installed version of sfnt2woff-zopfli?
| INSTALLFLAG=1 | ||
| else | ||
| WOFF2_BIN="woff2_compress" | ||
| echo "woff2_compress executable identified" |
There was a problem hiding this comment.
and here for woff2_compress
| @@ -93,6 +93,13 @@ if [ "$1" = "--install-dependencies" ] | |||
| cd "$CUR_DIR" || exit 1 | |||
| fi | |||
|
|
|||
| # If the binary is not found, look if it is installed system-wide | |||
There was a problem hiding this comment.
or perhaps better to introduce it in these blocks. Somewhere so that it is clear in the standard output trail that a system installed version is being applied rather than the approach used with the build-with-dependencies target. I will do the same for the Python installs depending upon how we approach them with version pinning.
|
In light of @anthrotype's excellent suggestion to establish reproducible builds from a Python build dependency standpoint and my desire to make this the case across all build dependencies, let's move this to a separate script with a new make target rather than creating a new build path that is determined by the presence of system wide installs of these web font build dependencies. I am happy to support this here but we should not make this the default if reproducible builds are to be a goal going forward. This PR proposal takes us in the opposite direction and is probably best suited for a new make target that is explicitly requested by the builder and is not the project build make target default. To support this, I need to change the current approach for both Python dependencies and ttfautohint as currently defined in the dependency install scripting. I am going to postpone the remaining planned design objectives for the v3.003 release and we will push this transition in our build chain as the last set of changes that we will make before we release the existing |
|
Rebased this PR on the |
|
Modified your OP to prevent automated closure of the associated issue report. I am going to merge this and use it as a basis for the script updates. This work will likely wind up on a different script path. Still trying to decide on the approach. Let's leave this open to continue the work. I will take care of the necessary changes to support the new make targets and the needs included in the work here will be part of those new targets. |
If sfnt2woff-zopfli and woff2_compress binaries are not found in the
installation directory targeted when the scripts are called with
--install-dependencies, then look if the binaries are installed
system-wide (i.e., in the $PATH).
IR #395.