-
-
Notifications
You must be signed in to change notification settings - Fork 626
Added ruble Ruble sign U+20BD #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great Pavel! Will add this on for our upcoming v4.000 release. Thanks for this contribution! |
And ignore the test failure. I need to look into the pipenv issue with our Python script testing. It is unrelated to this commit/these changes. |
Pavel, can I please have you confirm that these designs are your own work and that you are willing to contribute them to this project under the existing MIT license? |
Yes, sure. |
Yes = these are your designs Sure = MIT is OK? Sorry but I need to confirm licensing issues if there are upstream for these designs, including DejaVu. |
These are my designs and I am willing to contribute them to this project under the MIT license |
Thanks! Will try to build sets with these glyphs in them over the upcoming week. We will include them in the open v4.000 PR for users to download and try. |
Great! |
Merged into cyrillic-updates branch. Here are Hack version 4.000;[400b701]-dev builds that include these new glyphs and the updated designs to the Cyrillic te in #435 : Mind confirming that:
Let me know if you think we are good to go here and I will merge all of these changes to |
1)➕ Ruble is present in the ttf sets and renders how it should. |
Hmmm... let me change how I am coding the ruble glyph and try to rebuild. Thanks for checking. |
My error on coding the definitions for the subsetter. The compiler wanted the glyph name instead of Unicode code point. This is fixed in the releases attached to this post (Version 4.000;[d040a58]-dev): |
Everything seems fine at d040a58. |
Excellent! Let's merge these changes to |
macOS retina
