Skip to content

Upgrade Python build tooling #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Upgrade Python build tooling #457

merged 3 commits into from
Mar 25, 2019

Conversation

chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Oct 21, 2018

PR defines Py3.7 as the Python interpreter version for builds + increases all Python build tooling versions used in pipenv virtual build environment to current PyPI release versions.

These changes required modification of the glyph names used in the ttfautohint control instruction files as the fontmake compiler respects UFO source file spec'd names by default (instead of replacing with production names by default) in the upgraded version of the tooling defined in the Pipfile.lock here.

Build at ac48920:
Click to download, then unpack and install: build-ac48920c7.zip

updates to current PyPI versions
Convert away from production names following changes made in fontmake compiler dependencies.  The compiler respects UFO *.glif file specified name values as default with change in tooling that we made in  e97ee8a
@chrissimpkins
Copy link
Member Author

chrissimpkins commented Oct 21, 2018

I reviewed diffs of the binaries across these changes and there are numerous (900-1000 per variant) minor single unit contour changes (conversion from round to ceiling calculations?) and < 10 instruction set assembly changes per variant. All instruction set changes occurred in glyphs outside of the Basic Latin set that had a contour adjustment due to the new calculation approach used by the compiler tooling.

Should be gtg.

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Oct 21, 2018

Please note that if you intend to build fonts from source, are using an earlier version of fontmake and its associated dependencies, and are hinting with ttfautohint using the control instructions files in this repository, these changes may break your build. ttfautohint will not be able to identify the modified glyph names in the font files compiled with the previous build tooling specified here.

@chrissimpkins chrissimpkins added this to the v4.000 milestone Oct 21, 2018
@chrissimpkins chrissimpkins mentioned this pull request Feb 7, 2019
@chrissimpkins chrissimpkins merged commit ac48920 into dev Mar 25, 2019
@chrissimpkins chrissimpkins deleted the py37-build-upgrade branch March 25, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant