Skip to content

Conversation

@vaibhavbhalla2505
Copy link
Contributor

@vaibhavbhalla2505 vaibhavbhalla2505 commented Dec 18, 2025

BREAKING CHANGE

YES

Description

This pull request primarily updates the @sourceloop/core dependency to the latest major version and standardizes TypeScript generic class declarations for improved readability. There are also minor formatting adjustments in the package.json file.

Dependency update:

  • Upgraded @sourceloop/core from version ^15.0.1 to ^20.0.0 in package.json, ensuring compatibility with the latest features and bug fixes.

Fixes #99

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@vaibhavbhalla2505 vaibhavbhalla2505 self-assigned this Dec 18, 2025
@vaibhavbhalla2505 vaibhavbhalla2505 changed the title feat(ci-cd): add trivy scan feat(deps): upgrade sourceloop/core version Dec 18, 2025
@vaibhavbhalla2505 vaibhavbhalla2505 added the breaking breaking change label Dec 18, 2025
sourceloop core version upgrade

BREAKING CHANGE:
YES

GH-99
sourceloop core version upgrade

BREAKING CHANGE:
YES

GH-99
docs update

BREAKING CHANGE:
YES

GH-99
@sonarqubecloud
Copy link

SonarQube reviewer guide

Summary: Updates @sourceloop/core from v15 to v20 and removes Trivy security scan workflow

Review Focus:

  • Major version bump of @sourceloop/core dependency (v15→v20) which may introduce breaking changes
  • Removal of .github/workflows/trivy.yaml eliminates security scanning on PRs
  • Significant package-lock.json changes affecting multiple dependencies and their peer dependencies
  • Added JSDoc comment to consumer decorator

Start review at: package.json. This shows the core dependency change that drives all other modifications and is critical to understand the scope of the update before examining the extensive lock file changes.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sourceloop/core version upgrade

2 participants