Drop dangling local symbol occurrences - #491
Open
eseliger wants to merge 1 commit into
Open
Conversation
eseliger
force-pushed
the
local-symbol-information
branch
from
August 23, 2026 00:09
8d7f430 to
5373ad1
Compare
eseliger
force-pushed
the
local-symbol-information
branch
from
August 23, 2026 00:50
5373ad1 to
3d0f16e
Compare
eseliger
marked this pull request as ready for review
August 23, 2026 00:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concrete failure before this change
Given two indexed packages:
Package B previously emitted a
reference local 1occurrence forvalue, but its document contained noSymbolInformationforlocal 1. SCIP local symbols are scoped to one document, so package A's local symbol could not satisfy that reference. This change drops that dangling cross-document occurrence while preserving the valid local definitions and references inside package A.Longer-term
Ideally, package B's
valuereference should navigate to theLocalResult.valuedefinition in package A. SCIP can represent that by assigning the private property a stable declaration-derived global identity—global in the SCIP uniqueness sense, not exported in the TypeScript visibility sense—likely owned by the exported function whose return type exposes it. Both the definition in package A and references in other documents would then use that identity.That promotion requires deterministic handling for private declarations exposed through exported inferred or structural types. This PR intentionally implements the safe correctness fallback first: omitting an unrepresentable reference is preferable to emitting an invalid dangling local symbol.