clientv1: define SAMS user management RPCs#89
Merged
Conversation
kalanchan
changed the title
jac
approved these changes
May 14, 2025
jac
requested changes
May 14, 2025
Contributor
Author
|
@jac ready for review again! |
jac
force-pushed
the
kalan/add-user-management-rpcs
branch
from
e32f468 to
accf8a3
Compare
jac
approved these changes
May 19, 2025
unknwon
reviewed
Jun 4, 2025
Comment on lines
+36
to
+37
| // CreateUser creates a new SAMS user with the given email. | ||
| // Required scopes: sams::user::write |
Contributor
There was a problem hiding this comment.
Missing a blank line in between.
Contributor
|
@kalanchan hey |
Contributor
Author
what |
Contributor
What "what"? Read my review comments. |
Contributor
Author
no! busy |
Contributor
|
@kalanchan ping for followups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes CORE-991
This PR defines the proto defintions for 2 new SAMS RPCs -
CreateUserandDeleteUser. Implementation is added in https://github.com/sourcegraph/sourcegraph-accounts/pull/376Test plan
CI