clientv1: remove name field from createuser#92
Closed
kalanchan wants to merge 1 commit into
Closed
Conversation
jac
reviewed
May 23, 2025
Member
There was a problem hiding this comment.
When updating protobuf removing fields like this is discouraged.
https://protobuf.dev/programming-guides/proto3/#updating
If you do want to remove something it should be marked as reserved but the field number must be kept to ensure compatibility with clients who might be using different versions of the sdk.
By default all fields in proto3 are optional. As such we can keep the name field and just not supply it from EP.
Contributor
Author
|
thanks @jac ! going to close off this PR then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to https://github.com/sourcegraph/sourcegraph/pull/5351
Removes name field from RPC and keeps email as the only required
Test plan
CI