Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

telemetry: improve inline docstrings#57104

Merged
bobheadxi merged 1 commit intomainfrom
09-27-telemetry_improve_inline_docstrings
Sep 28, 2023
Merged

telemetry: improve inline docstrings#57104
bobheadxi merged 1 commit intomainfrom
09-27-telemetry_improve_inline_docstrings

Conversation

@bobheadxi
Copy link
Copy Markdown
Member

@bobheadxi bobheadxi commented Sep 27, 2023

We're getting logs of questions about what we are and are not exporting. This refreshes our inline docs, with the intent of being able to generate a protojson schema that we can point to and say "this, this is what we are and are not exporting" 😄

Test plan

n/a docs-only changes

@cla-bot cla-bot Bot added the cla-signed label Sep 27, 2023
@bobheadxi
Copy link
Copy Markdown
Member Author

bobheadxi commented Sep 27, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bobheadxi bobheadxi requested review from a team, dadlerj and nathan-downs September 27, 2023 21:59
@sourcegraph-bot
Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@bobheadxi
Copy link
Copy Markdown
Member Author

...sorry @unknwon I'm going to backport this too, otherwise we might get funky conflicts on the generated code if anything gets added

@unknwon unknwon added the backport/improvement Final touching of existing features label Sep 27, 2023
@bobheadxi bobheadxi merged commit 8b32774 into main Sep 28, 2023
@bobheadxi bobheadxi deleted the 09-27-telemetry_improve_inline_docstrings branch September 28, 2023 16:52
sourcegraph-release-bot pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/improvement Final touching of existing features backport 5.2 cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants