This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Change titles of some Grafana panels#63952
Open
varungandhi-src wants to merge 3 commits intomainfrom
Open
chore: Change titles of some Grafana panels#63952varungandhi-src wants to merge 3 commits intomainfrom
varungandhi-src wants to merge 3 commits intomainfrom
Conversation
github-actions
bot
added
team/graph
varungandhi-src
commented
Jul 19, 2024
| }, | ||
| { | ||
| Title: "Containers: Provisioning Indicators (not available on server)", | ||
| Title: "Containers: Resource utilization (not available on server)", |
Contributor
Author
There was a problem hiding this comment.
I don't understand why this title is different from the other one - is the distinction between service-level (aggregated across multiple containers) vs container-level utilization?
varungandhi-src
commented
Jul 19, 2024
| // These observables should only use cAdvisor metrics, and are thus only available on | ||
| // Kubernetes and docker-compose deployments. | ||
| const TitleProvisioningIndicators = "Provisioning indicators (not available on server)" | ||
| const TitleResourceUtilization = "Resource utilization (not available on server)" |
Contributor
Author
There was a problem hiding this comment.
Can we get rid of the (not available on server)/is the above doc comment still accurate?
michaellzc
requested review from
a team and
craigfurman
and removed request for
a team
michaellzc
approved these changes
Jul 25, 2024
burmudar
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier name "Provisioning indicators" seems a bit more abstract compared
to "Resource utilization". When I was searching the dashboards for resource utilization,
even after being told that a dashboard had that information, I missed it because I didn't
think to un-collapse the panel titled "Provisioning indicators" (I incorrectly guessed
it must've some generic details related to resource allocation, not usage).
Even the doc comments have this:
So let's make the titles reflect this directly.
Test plan
n/a