Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4271 +/- ##
============================================
- Coverage 77.40% 55.11% -22.29%
============================================
Files 485 350 -135
Lines 38023 32379 -5644
============================================
- Hits 29430 17845 -11585
- Misses 6273 13017 +6744
+ Partials 2320 1517 -803
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 295 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e798e29 to
e12556b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #4222 #4266
Description
This adds a TTLCache to the HTTP API Transaction middleware.
There is a discussion to be had here:
This only adds a transaction TTL to explicit transactions made through the HTTP API, embedded usage isn't changed. In an ideal case we would have no transaction TTL since I think it limits the user. The downside of the HTTP API is that transactions have a possible of falling into limbo due to network delivery issues beyond our control. If a transaction is left open indefinitely it will seriously impact and degrade the entire database until eventually panicing. So the HTTP API needs the TTL, the discussion is whether it should apply to all manual transaction creation, regardless if using the HTTP API.
Tasks
How has this been tested?
Just a single integration test, once the above discussion has been resolved I'll expand them.
Specify the platform(s) on which this was tested: