Skip to content

refactor: Rename options enumerable#4527

Draft
islamaliev wants to merge 2 commits intosourcenetwork:developfrom
islamaliev:refactor/rename-options-enumerable
Draft

refactor: Rename options enumerable#4527
islamaliev wants to merge 2 commits intosourcenetwork:developfrom
islamaliev:refactor/rename-options-enumerable

Conversation

@islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #4526

Description

Rename options.Lister to options.Enumerable

@islamaliev islamaliev added this to the DefraDB v1.0 milestone Feb 13, 2026
@islamaliev islamaliev requested a review from a team February 13, 2026 20:41
@islamaliev islamaliev self-assigned this Feb 13, 2026
@islamaliev islamaliev added the refactor This issue specific to or requires *notable* refactoring of existing codebases and components label Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.13%. Comparing base (ff5fc62) to head (4403d10).

Files with missing lines Patch % Lines
internal/db/txn.go 0.00% 6 Missing ⚠️
cbindings/wrapper_tx.go 0.00% 1 Missing ⚠️
http/client_tx.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4527      +/-   ##
===========================================
- Coverage    76.15%   76.13%   -0.02%     
===========================================
  Files          521      521              
  Lines        41892    41892              
===========================================
- Hits         31900    31892       -8     
- Misses        7517     7522       +5     
- Partials      2475     2478       +3     
Flag Coverage Δ
all-tests 76.13% <74.19%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cbindings/collection.go 61.79% <ø> (ø)
cbindings/wrapper.go 80.24% <100.00%> (ø)
cbindings/wrapper_collection.go 73.84% <100.00%> (ø)
client/db.go 88.24% <ø> (ø)
client/options/enumerable.go 92.31% <ø> (ø)
client/options/identity.go 100.00% <ø> (ø)
client/p2p.go 0.00% <ø> (ø)
http/client.go 65.78% <100.00%> (ø)
http/client_acp.go 83.89% <100.00%> (ø)
http/client_collection.go 60.67% <100.00%> (ø)
... and 24 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5fc62...4403d10. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor This issue specific to or requires *notable* refactoring of existing codebases and components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename options Lister to Enumerable

2 participants