Skip to content

fix: Replicator backfill drops documents - #4823

Draft
nasdf wants to merge 1 commit into
sourcenetwork:developfrom
nasdf:nasdf/issue/4822
Draft

fix: Replicator backfill drops documents#4823
nasdf wants to merge 1 commit into
sourcenetwork:developfrom
nasdf:nasdf/issue/4822

Conversation

@nasdf

@nasdf nasdf commented May 19, 2026

Copy link
Copy Markdown
Member

Relevant issue(s)

Resolves #4822

Description

This PR adds a reproducible test for the issue but does not yet address it.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Added a reproducible test.

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf self-assigned this May 19, 2026
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.88%. Comparing base (04a2d1e) to head (0a5fe22).
⚠️ Report is 6 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (04a2d1e) and HEAD (0a5fe22). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (04a2d1e) HEAD (0a5fe22)
all-tests 2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4823      +/-   ##
===========================================
- Coverage    76.28%   67.88%   -8.40%     
===========================================
  Files          537      537              
  Lines        44068    44166      +98     
===========================================
- Hits         33615    29980    -3635     
- Misses        7859    11709    +3850     
+ Partials      2594     2477     -117     
Flag Coverage Δ
all-tests 67.88% <ø> (-8.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 167 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a2d1e...0a5fe22. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replicator backfill drops documents

1 participant