test: Isolate wizard config files - #5207
Open
iverc wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (52)
|
| Layer / File(s) | Summary |
|---|---|
Temporary root assignment and test validation cli/wizard/utils_test.go |
setConfigValueForTest uses t.TempDir() for an empty RootDir. The test verifies that config.yaml is created under the temporary root. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Merge Risk: ⚪ Minimal · up to ac84c
This change isolates wizard test configuration in automatically cleaned temporary directories without affecting production behavior or dependencies; no actionable merge-blocking risk remains after normal checks and review.
Assessment Against Linked Issues
| Objective | Addressed | Explanation |
|---|---|---|
Use a temporary directory for test configuration writes [#4682] |
✅ |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5207 +/- ##
===========================================
+ Coverage 76.39% 76.45% +0.06%
===========================================
Files 647 647
Lines 51690 51690
===========================================
+ Hits 39486 39517 +31
+ Misses 8874 8852 -22
+ Partials 3330 3321 -9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
islamaliev
approved these changes
Aug 31, 2026
islamaliev
left a comment
islamaliev
left a comment
Contributor
There was a problem hiding this comment.
The fix is legit but the test coverage gives me mixed feelings
Comment on lines
+54
to
+61
| func TestSetConfigValueForTestUsesTemporaryRoot(t *testing.T) { | ||
| ctx := &WizardContext{} | ||
| setConfigValueForTest(t, ctx, "keyring.namespace", "test") | ||
|
|
||
| if _, err := os.Stat(filepath.Join(ctx.RootDir, "config.yaml")); err != nil { | ||
| t.Fatalf("expected config in temporary root: %v", err) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: you cover with tests and internal helper function for tests. This looks unconventional. I'd remove it
ChrisBQu
approved these changes
Aug 31, 2026
ChrisBQu
left a comment
ChrisBQu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #4682
Description
Makes the shared wizard test helper assign a temporary root directory whenever a test context does not provide one. This prevents configuration reads and writes from creating
config.yamlin the package checkout.Adds a regression test for the temporary-root fallback. Production behavior and dependencies are unchanged.
Tasks
How has this been tested?
go test ./cli/wizard -run TestSetConfigValueForTestUsesTemporaryRoot -count=1go test ./cli/wizard -skip SystemKeyring -count=1config.yamlin the worktreeTested on macOS.