refactor: Rename sourcehub to remote/vera acp terminology - #5216
Open
shahzadlone wants to merge 6 commits into
Open
refactor: Rename sourcehub to remote/vera acp terminology#5216shahzadlone wants to merge 6 commits into
shahzadlone wants to merge 6 commits into
Conversation
shahzadlone
added
refactor
shahzadlone
changed the title
shahzadlone
force-pushed
the
lone/rename-sourcehub-to-vera-and-remote-acp
branch
from
September 1, 2026 00:10
f19711b to
02a01dd
Compare
shahzadlone
changed the title
shahzadlone
force-pushed
the
lone/rename-sourcehub-to-vera-and-remote-acp
branch
from
September 1, 2026 00:51
02a01dd to
75667e3
Compare
ChrisBQu
approved these changes
Sep 1, 2026
ChrisBQu
left a comment
ChrisBQu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but, question: Why did you bundle the version bump with this rename?
I'm not really bothered by it, it clearly has to happen. But it's a different thing?
Member
Author
As mentioned in the PR description those first commits can be ignored, the bump there is necessary and i wanted to see the full thing pass the ci when the bump pr was not merged (those are are cherry picked commits from my outher branch, kind of like manual PR stack). Will remove it in next rebase with develop as its now merged. |
shahzadlone
force-pushed
the
lone/rename-sourcehub-to-vera-and-remote-acp
branch
from
September 1, 2026 20:41
75667e3 to
e34c461
Compare
shahzadlone
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5216 +/- ##
===========================================
- Coverage 76.42% 76.39% -0.03%
===========================================
Files 648 648
Lines 51754 51769 +15
===========================================
- Hits 39551 39548 -3
- Misses 8876 8889 +13
- Partials 3327 3332 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Pin Vera module with a matching published container image, then update the SDK imports and runtime fixtures. NOTE: this is likely a breaking change as remote ACP connections must target Vera-compatible nodes now.
Replace DefraDB-facing SourceHub terminology with Remote DAC while reserving Vera for the backing repository and network. Rename Go and C APIs, configuration and CLI surfaces, test harnesses, and generated docs. Note: breaking change becuase the document ACP type source-hub is now remote. Configuration moved from acp.document.sourceHub.* to acp.document.remote.*, --source-hub-address is now --remote-dac-address, and SourceHub Go/C symbols, test targets, and image variables were replaced by Remote DAC or Vera names.
shahzadlone
force-pushed
the
lone/rename-sourcehub-to-vera-and-remote-acp
branch
from
September 3, 2026 02:27
e34c461 to
c484229
Compare
Member
Author
|
@jsimnz Here is the only remaining 
|
Adopt the planned Vera LogID terminology across DefraDB Go and C APIs, configuration, and tests while adapting it to Vera’s current ChainID SDK option at the integration boundary. BREAKING CHANGE: Remote DAC ChainID fields, builders, and configuration are now named LogID. Use RemoteDACLogID, SetLogID, acp.document.remote.LogID, DEFRA_ACP_DOCUMENT_REMOTE_LOGID, and remoteDACLogID.
Document the SourceHub-to-Vera and Remote DAC migration in BREAKLOG.md. Explain how intentional one-off breaking changes outside the standing VERSIONING.md exceptions are communicated and add contributor guidance.
shahzadlone
force-pushed
the
lone/rename-sourcehub-to-vera-and-remote-acp
branch
from
September 3, 2026 02:35
c484229 to
662bcf5
Compare
ChrisBQu
approved these changes
Sep 3, 2026
| // Document ACP | ||
| {Path: []string{"DocumentACP", "DocumentACPType"}, Value: "local"}, | ||
| {Path: []string{"DocumentACP", "Path"}, Value: ""}, | ||
| {Path: []string{"DocumentACP", "RemoteDACLogID"}, Value: "log-a"}, |
Collaborator
There was a problem hiding this comment.
praise: Nice catching that this belongs here, since its beyond a simple find-and-replacee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #5215
Description
ChainID->LogIDto avoid future breaking changes when vera does it.Todo
BREAKING