feat: Add P2P syncing of lenses#122
Merged
Merged
Conversation
AndrewSisley
added a commit
to sourcenetwork/defradb
that referenced
this pull request
Sep 15, 2025
## Relevant issue(s) Resolves #4007 ## Description Tweaks the `net.Host` interface easier to consume by removing elements that require direct reference to the exact concrete type. This is required by Lens, so that a trimmed down `net.Host` interface can be consumed without making Lens dependant on Defra. The alternative is to extract `net` to a new repository - this may be desirable long term, so Lens can spin up a `net.Host` instance, but even if we go that route I'd be in favour of this change as it allows external apps to consume the interface without a direct reference. `net.Host.PeerInfo()` should now be the only interface member containing a a concrete custom type, I have left it, as this function is syntax sugar around `ID()` and `Addrs()` and is never going to be required by anything consuming the type. The Lens code may be viewed in this PR: sourcenetwork/lens#122 - see `host-go/p2p/host.go` for the re declaration of a subset of the `net.Host` interface.
AndrewSisley
force-pushed
the
117-p2p-2
branch
11 times, most recently
from
c0352d2 to
997e3f8
Compare
AndrewSisley
force-pushed
the
117-p2p-2
branch
from
997e3f8 to
0619ce0
Compare
AndrewSisley
changed the title
fredcarle
reviewed
Sep 19, 2025
fredcarle
left a comment
fredcarle
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Just one minor todo before merge.
I do like our new testing frameowrk but I find myself having to relearn it everytime I review updated/new test actions lol.
| func (test *Test) Execute(t testing.TB) { | ||
| ctx := context.Background() | ||
| ctx, cancel := context.WithTimeout(ctx, 1*time.Second) | ||
| ctx, cancel := context.WithTimeout(ctx, 5*time.Second) |
Collaborator
There was a problem hiding this comment.
todo: Please document why 5 second is specifically important/chosen.
Collaborator
Author
There was a problem hiding this comment.
:) I don't remember changing this to 5, It will probably be reverted. The tests are quick and there is nothing special about either number.
- Revert timeout
Collaborator
Author
Yeah, I have that problem when working in Defra now 😅 The migration has started, and I have a branch that (mostly) updates the AddCollection action, but I was hoping to get far more done before the end of this sprint - so we can use it for the v1 testing. |
fredcarle
approved these changes
Sep 19, 2025
fredcarle
pushed a commit
to sourcenetwork/defradb
that referenced
this pull request
Mar 4, 2026
## Relevant issue(s) Resolves #4007 ## Description Tweaks the `net.Host` interface easier to consume by removing elements that require direct reference to the exact concrete type. This is required by Lens, so that a trimmed down `net.Host` interface can be consumed without making Lens dependant on Defra. The alternative is to extract `net` to a new repository - this may be desirable long term, so Lens can spin up a `net.Host` instance, but even if we go that route I'd be in favour of this change as it allows external apps to consume the interface without a direct reference. `net.Host.PeerInfo()` should now be the only interface member containing a a concrete custom type, I have left it, as this function is syntax sugar around `ID()` and `Addrs()` and is never going to be required by anything consuming the type. The Lens code may be viewed in this PR: sourcenetwork/lens#122 - see `host-go/p2p/host.go` for the re declaration of a subset of the `net.Host` interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #117
Description
Adds the ability to sync lenses over a P2P network.
Sync is done synchronously, on demand. Consumers, including Defra, will manage concurrency and timing.
As with the
StorePR, testing is very light atm due to time pressure. Testing should ideally be expanded fairly soon.