-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update publish script for multi-platform builds #258
Conversation
Reviewer's Guide by SourceryThis PR updates the publish script to build and publish multi-platform VSIX packages. Sequence diagram for multi-platform build and publish processsequenceDiagram
participant Matrix as Build Matrix
participant Runner as GitHub Runner
participant Artifacts as Artifacts Storage
participant VSCode as VS Code Marketplace
participant GitHub as GitHub Releases
Matrix->>Runner: Start parallel builds for each platform
loop For each platform
Runner->>Runner: Download binaries
Runner->>Runner: Update version
Runner->>Runner: Package VSIX
Runner->>Artifacts: Upload platform-specific VSIX
end
Runner->>Artifacts: Download all artifacts
Runner->>VSCode: Publish all platform VSIXs
Runner->>GitHub: Create release with all VSIXs
[FILTERED - Architecture diagrams are low quality] Architecture diagram for multi-platform VSIX build and publish workflowflowchart TB
subgraph package[Package VSIX Job Matrix]
direction TB
win[Windows x64]-->pkg1[Package VSIX]
linux[Linux x64]-->pkg2[Package VSIX]
macx64[macOS x64]-->pkg3[Package VSIX]
macarm[macOS ARM64]-->pkg4[Package VSIX]
pkg1 & pkg2 & pkg3 & pkg4 -->|Upload| artifacts[(Artifacts Storage)]
end
subgraph publish[Publish Job]
direction TB
download[Download Artifacts]-->merge[Merge Artifacts]
merge-->publish_vsix[Publish to VS Code Marketplace]
merge-->create_release[Create GitHub Release]
end
package-->|Dependencies|publish
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Hellebore - I've reviewed your changes - here's some feedback:
Overall Comments:
- Since this PR adds multi-platform builds, consider updating the checklist to verify the VSIX package works on all target platforms (Windows, Linux, Mac x64, Mac ARM64)
Here's what I looked at during the review
- 🟢 Functionality: all looks good
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Do you actually have to merge this before testing it? Or can you test it and remove the TODOs before merging?
Checklist
package.json
oryarn.lock
have changed, then test the VSIX built byyarn run vsce package
works from a direct installSummary by Sourcery
CI: