Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trying pre-release #259

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

Hellebore
Copy link
Contributor

@Hellebore Hellebore commented Jan 14, 2025

Checklist

  • If package.json or yarn.lock have changed, then test the VSIX built by yarn run vsce package works from a direct install

Summary by Sourcery

CI:

  • Publish a pre-release version of the VSIX package when a new release is created.

Copy link
Contributor

sourcery-ai bot commented Jan 14, 2025

Reviewer's Guide by Sourcery

This pull request introduces a pre-release flag when packaging the VS Code extension, to allow testing before an official release.

Sequence diagram for the modified VS Code extension packaging process

sequenceDiagram
    participant GH as GitHub Actions
    participant VSCE as VSCE Tool
    participant Artifact as VSIX Artifact

    GH->>VSCE: Run package command
    Note over VSCE: New --pre-release flag
    VSCE->>Artifact: Generate pre-release VSIX
    GH->>Artifact: Rename with version and target
Loading

Flow diagram for the updated publish workflow

flowchart LR
    A[Start] --> B[Update Version]
    B --> C[Package Extension]
    C -->|--pre-release flag| D[Generate VSIX]
    D --> E[Rename VSIX]
    E --> F[End]

    style C fill:#f9f,stroke:#333,stroke-width:2px
Loading

File-Level Changes

Change Details Files
Added the --pre-release flag to the packaging command.
  • The vsce package command now includes the --pre-release flag to generate pre-release versions of the extension.
  • A TODO comment was added to remove the pre-release flag after testing is complete to resume normal releases.
.github/workflows/publish.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hellebore - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 Functionality: all looks good
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

LangSmith trace

Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Hellebore Hellebore merged commit 591c3d8 into main Jan 14, 2025
1 check passed
@Hellebore Hellebore deleted the nick/fix/update-packaging-to-prerelease branch January 14, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant