-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update back to real releases after testing #260
Conversation
Reviewer's Guide by SourceryThis PR updates the release process to create real releases instead of pre-releases. This was done by removing the [FILTERED - Architecture diagrams are low quality] Architecture diagram showing the release pipeline componentsgraph LR
A[GitHub Actions] --> B[VSCode Extension Package]
B --> C[VSCode Marketplace]
B --> D[GitHub Release]
subgraph Release Process
B
end
subgraph Distribution Channels
C
D
end
note[Note: All components now<br/>publish full releases<br/>instead of pre-releases]
style note fill:#f9f,stroke:#333,stroke-width:2px
Flow diagram of the updated release processgraph TD
A[Start Release Process] --> B[Update Version Number]
B --> C[Package VSCode Extension]
C --> D[Rename VSIX File]
D --> E[Download Artifacts]
E --> F[Publish to VSCode Marketplace]
F --> G[Create GitHub Release]
G --> H[End Release Process]
style C fill:#90EE90,stroke:#006400
style F fill:#90EE90,stroke:#006400
style G fill:#90EE90,stroke:#006400
note[Note: Green nodes indicate<br/>removal of pre-release flags]
style note fill:#f9f,stroke:#333,stroke-width:2px
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Hellebore - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 Functionality: all looks good
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Checklist
package.json
oryarn.lock
have changed, then test the VSIX built byyarn run vsce package
works from a direct installSummary by Sourcery
Publish full releases of the VS Code extension instead of pre-releases.
CI:
Deployment: