Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update back to real releases after testing #260

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Hellebore
Copy link
Contributor

@Hellebore Hellebore commented Jan 15, 2025

Checklist

  • If package.json or yarn.lock have changed, then test the VSIX built by yarn run vsce package works from a direct install

Summary by Sourcery

Publish full releases of the VS Code extension instead of pre-releases.

CI:

  • Publish VS Code extension as a full release.

Deployment:

  • Create full releases instead of pre-releases.

Copy link
Contributor

sourcery-ai bot commented Jan 15, 2025

Reviewer's Guide by Sourcery

This PR updates the release process to create real releases instead of pre-releases. This was done by removing the --pre-release flag from the vsce package and vsce publish commands, and by setting prerelease: false in the release-action configuration.

[FILTERED - Architecture diagrams are low quality] Architecture diagram showing the release pipeline components

graph LR
    A[GitHub Actions] --> B[VSCode Extension Package]
    B --> C[VSCode Marketplace]
    B --> D[GitHub Release]

    subgraph Release Process
    B
    end

    subgraph Distribution Channels
    C
    D
    end

    note[Note: All components now<br/>publish full releases<br/>instead of pre-releases]
    style note fill:#f9f,stroke:#333,stroke-width:2px
Loading

Flow diagram of the updated release process

graph TD
    A[Start Release Process] --> B[Update Version Number]
    B --> C[Package VSCode Extension]
    C --> D[Rename VSIX File]
    D --> E[Download Artifacts]
    E --> F[Publish to VSCode Marketplace]
    F --> G[Create GitHub Release]
    G --> H[End Release Process]

    style C fill:#90EE90,stroke:#006400
    style F fill:#90EE90,stroke:#006400
    style G fill:#90EE90,stroke:#006400

    note[Note: Green nodes indicate<br/>removal of pre-release flags]
    style note fill:#f9f,stroke:#333,stroke-width:2px
Loading

File-Level Changes

Change Details Files
Removed the pre-release flag when packaging the VSIX.
  • Removed the --pre-release flag from the yarn vsce package command
.github/workflows/publish.yml
Removed the pre-release flag when publishing the VSIX.
  • Removed the --pre-release flag from the yarn vsce publish command
.github/workflows/publish.yml
Ensured the GitHub release is not marked as a pre-release.
  • Set prerelease: false in the release action configuration
.github/workflows/publish.yml
Removed TODO comments.
  • Removed TODO comments related to making the release not a pre-release
.github/workflows/publish.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hellebore - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 Functionality: all looks good
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

LangSmith trace

Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Hellebore Hellebore merged commit 936e27e into main Jan 15, 2025
1 check passed
@Hellebore Hellebore deleted the nick/feat/switch-back-from-pre-release branch January 15, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant