Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN Turbo/Fabric migration #88

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

RN Turbo/Fabric migration #88

wants to merge 25 commits into from

Conversation

ian-wd
Copy link

@ian-wd ian-wd commented Mar 7, 2025

Pull Request: react-native-sketch-canvas

Description

Turbo/Fabric View migration

Type of Change

  • New Plugin
  • Feature Addition
  • Bug Fix
  • Performance Improvement
  • Code Refactoring
  • Documentation Update
  • Other (please describe):

Testing Performed

  • Unit Tests
  • Integration Tests
  • Component Tests
  • Manual Testing
  • Edge Cases Verified

Test Results

image

Breaking Changes

  • Bumped minimum RN version to v0.76.7
  • New Architecture must be enabled

@iBotPeaches
Copy link
Member

@nemanjar7 - Can you pull this sample out down and give it a shot locally? Want to have someone else test to be sure we understand this movement to New Arch

@nemanjar7
Copy link

Screenshot 2025-03-12 at 1 39 56 PM

Are these logs supposed to be here?
Screenshot 2025-03-12 at 1 34 01 PM

Android:

android1.mov
android2.mov

iOS:

ios1.mov
ios2.mov

Seems fine to me, the only thing I noticed is that if we don't clear the screen on one canvas, it tends to transfer those changes to the new screen. Not sure if the app is set up that way since it's just example app.

@iBotPeaches
Copy link
Member

The logs are intentional since just a sample app to see what's it's doing. The drawing persisting seems odd - I'd like @ian-wd to comment on that.

@ian-wd
Copy link
Author

ian-wd commented Mar 14, 2025

The logs are intentional since just a sample app to see what's it's doing. The drawing persisting seems odd - I'd like @ian-wd to comment on that.

ill check this weekend, I haven't encountered that I'm mostly running this on android

@ian-wd
Copy link
Author

ian-wd commented Mar 17, 2025

Fixed iOS fabric view/sketchcanvas cleanup

ios-cleanup-fix.mp4

Comment on lines 26 to 30
run: npm publish --access public
run: yarn npm publish --access public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefixing yarn in front of an npm command seems odd

@ian-wd ian-wd marked this pull request as ready for review March 24, 2025 11:11
@ian-wd ian-wd changed the title [WIP] RN Turbo/Fabric migration RN Turbo/Fabric migration Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants