-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: implement RevIndexOps
for mem_revindex
, and implement generic CounterGather
struct in Rust
#3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## impl_revindex #3584 +/- ##
=================================================
- Coverage 87.68% 87.59% -0.10%
=================================================
Files 137 136 -1
Lines 22717 23043 +326
Branches 2280 2273 -7
=================================================
+ Hits 19919 20184 +265
- Misses 2473 2530 +57
- Partials 325 329 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…nto impl_revindex_cg
for more information, see https://pre-commit.ci
…nto impl_revindex_cg
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RevIndex
directly from DiskRevIndex
RevIndexOps
for mem_revindex
, and implement generic CounterGather
struct in Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a PR into #3545
This PR mimics the Python layer by having RocksDB databases return a
CounterGather
object directly; doing this responsibly meant fully implementingRevIndexOps
forRevIndex
in memory, as well as fleshing out the whole Python FFI layer 🎉Current benchmarks: