Skip to content

Extract config_file method from action_class to enable external access #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −4
Open

Extract config_file method from action_class to enable external access #647

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a67e577
Initial plan
Copilot Sep 11, 2025
5b0278c
Extract config_file method from action_class to enable external access
Copilot Sep 11, 2025
13f62b2
Extract config_file logic to helpers.rb
Copilot Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions resources/site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@
description: 'Additional helper modules to include in the site template',
coerce: proc { |p| p.is_a?(Array) ? p : [p] }

def config_file
::File.join(conf_dir, "#{name}.conf")
Copy link
Copy Markdown
Member

@damacus damacus Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this to the helpers.rb

Copy link
Copy Markdown
Contributor Author

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted the config_file logic to a new nginx_site_config_file helper method in helpers.rb. The resource method now delegates to the helper while maintaining external accessibility. (13f62b2)

end

action_class do
include Nginx::Cookbook::ResourceHelpers

def config_file
::File.join(new_resource.conf_dir, "#{new_resource.name}.conf")
end

def config_file_disabled
"#{config_file}.disabled"
end
Expand Down
24 changes: 24 additions & 0 deletions spec/unit/resources/site_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,28 @@

it { is_expected.to delete_file('/etc/nginx/conf.http.d/default.conf') }
end

context 'config_file method accessibility' do
recipe do
nginx_install 'distro'

site = nginx_site 'test-site' do
conf_dir '/etc/nginx/sites-available'
action :create
end

# This tests the new functionality - accessing config_file on the resource instance
ruby_block 'test_config_file_access' do
block do
expected_path = '/etc/nginx/sites-available/test-site.conf'
actual_path = site.config_file
raise "Expected #{expected_path}, got #{actual_path}" unless actual_path == expected_path
end
action :run
end
end

it { is_expected.to create_template('/etc/nginx/sites-available/test-site.conf') }
it { is_expected.to run_ruby_block('test_config_file_access') }
end
end