fix: align client configs with server settings #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in issue #189, make settings in the client configs (E.G. `auth`, `cipher`, `compress`, etc) match their server counterparts. This eliminates warnings in the OpenVPN log about inconsistent option usage. In addition, document how the `openvpn_user` resource works, including showing how additional configuration options can be added to client conf files (using `additional_vars` and `cookbook_user_conf`) Signed-off-by: Josh Gitlin <[email protected]>
Parenthesize lazy blocks to make block association explicit and resolve Lint/AmbiguousBlockAssociation warning. Signed-off-by: Josh Gitlin <[email protected]>
Remove incorrect parentheses that caused Ruby syntax errors.
The original lazy { } syntax is correct for Chef resources.
Signed-off-by: Josh Gitlin <[email protected]>
Bring the bundled client templates into parity with the inline variant by passing through the computed compression flag, and ensure the client config writes a full compress directive so OpenVPN accepts the setting. Co-authored-by: Josh Gitlin <jgitlin pinnacle21.com> Signed-off-by: Dan Webb <[email protected]>
Signed-off-by: Dan Webb <[email protected]>
Signed-off-by: Dan Webb <[email protected]>
Signed-off-by: Dan Webb <[email protected]>
Slowest examplesTop 5 slowest examples (1.08 seconds, 100% of total time)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.