Skip to content

feat!: migrate ufw to custom resources#95

Merged
damacus merged 3 commits into
mainfrom
refactor/ufw-custom-resources
Apr 14, 2026
Merged

feat!: migrate ufw to custom resources#95
damacus merged 3 commits into
mainfrom
refactor/ufw-custom-resources

Conversation

@damacus

@damacus damacus commented Apr 13, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the legacy recipe-and-attribute workflow with a ufw_firewall custom resource and shared helper module
  • add LIMITATIONS.md, resource documentation, ChefSpec coverage, and a new test cookbook/InSpec default suite
  • modernize the kitchen and CI platform matrix for current Debian and Ubuntu targets and remove the legacy recipes/, attributes/, and kitchen.exec.yml structure

Verification

  • cookstyle
  • chef exec rspec --format documentation
  • chef exec berks install
  • chef exec kitchen converge default-ubuntu-2404
  • second chef exec kitchen converge default-ubuntu-2404 completed with Infra Phase complete, 0/11 resources updated
  • chef exec kitchen verify default-ubuntu-2404

@damacus damacus requested a review from a team as a code owner April 13, 2026 22:11
@damacus damacus changed the title refactor: migrate ufw to custom resources feat!: migrate ufw to custom resources Apr 13, 2026
@damacus damacus force-pushed the refactor/ufw-custom-resources branch 5 times, most recently from b8da4ee to 2f0ed8d Compare April 14, 2026 07:54
Signed-off-by: Dan Webb <dan.webb@damacus.io>
@damacus damacus force-pushed the refactor/ufw-custom-resources branch 4 times, most recently from 7255f3d to e875392 Compare April 14, 2026 09:28
Signed-off-by: Dan Webb <dan.webb@damacus.io>
@damacus damacus force-pushed the refactor/ufw-custom-resources branch from e875392 to 756c072 Compare April 14, 2026 09:31
@github-actions

Copy link
Copy Markdown

Slowest examples

Top 10 slowest examples (0.52 seconds, 100% of total time)
Example Description Time in seconds
spec/unit/resources/ufw_firewall_spec.rb:22 ufw_firewall with explicit rules is expected to install firewall "default" 0.10825
spec/unit/resources/ufw_firewall_spec.rb:24 ufw_firewall with explicit rules is expected to create firewall_rule "http" 0.09813
spec/unit/resources/ufw_firewall_spec.rb:39 ufw_firewall with action :delete is expected to disable firewall "default" 0.06456
spec/unit/resources/ufw_firewall_spec.rb:23 ufw_firewall with explicit rules is expected to create firewall_rule "ssh" 0.06407
spec/unit/resources/ufw_firewall_spec.rb:25 ufw_firewall with explicit rules is expected to create firewall_rule "dns" 0.0634
spec/unit/resources/ufw_firewall_spec.rb:40 ufw_firewall with action :delete is expected to run execute "reset default ufw rules" 0.0596
spec/unit/resources/ufw_firewall_spec.rb:41 ufw_firewall with action :delete is expected to purge apt_package "ufw" 0.05606
spec/unit/libraries/helpers_spec.rb:14 UfwCookbook::Helpers#normalized_rules normalizes array-form rules into a hash keyed by rule name 0.01249
spec/unit/libraries/helpers_spec.rb:38 UfwCookbook::Helpers#recipe_rules_from_node collects cookbook and recipe scoped firewall rules from the expanded run list 0.00075
spec/unit/libraries/helpers_spec.rb:30 UfwCookbook::Helpers#rule_command maps nil and create to allow for firewall_rule compatibility 0.00033

@damacus damacus merged commit 0bd06b8 into main Apr 14, 2026
14 checks passed
@damacus damacus deleted the refactor/ufw-custom-resources branch April 14, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant