fix: re-enable Virgool with message-based detection#2584
Open
mohamedsolaiman wants to merge 2 commits intosoxoj:mainfrom
Open
fix: re-enable Virgool with message-based detection#2584mohamedsolaiman wants to merge 2 commits intosoxoj:mainfrom
mohamedsolaiman wants to merge 2 commits intosoxoj:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running maigret for an OSINT investigation I noticed Virgool was disabled and returning false results. The site sits behind Cloudflare and returns HTTP 200 for every request, so the old
status_codecheck was useless.Switched to
checkType: messagewith content-based detection:presenseStrs: ["\"bio\""]— thebioJSON key only appears in real SSR profile payloads, not in the CF challenge HTMLabsenceStrs: ["۴۰۴"]— Persian digits for 404 shown on not-found pageserrorsmapping for the<noscript>JS-cookie wall so users get a clear UNKNOWN instead of a false positiveprotection: ["cf_js_challenge"]to flag the Cloudflare protectionFirst tried just flipping the checkType, then realized I needed the proper detection strings. Tested mentally against both claimed/unclaimed scenarios and the JS challenge case.
Closes #2579