refactor: reduce cognitive complexity of get_ai_analysis#2586
Open
mohamedsolaiman wants to merge 2 commits intosoxoj:mainfrom
Open
refactor: reduce cognitive complexity of get_ai_analysis#2586mohamedsolaiman wants to merge 2 commits intosoxoj:mainfrom
mohamedsolaiman wants to merge 2 commits intosoxoj:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking through the AI analysis code and realized
get_ai_analysiswas doing too much in one function — HTTP error handling, SSE stream parsing, spinner management, all mixed together. The function had a cognitive complexity problem and also a bug wherefull_responsewas never actually populated (the return was always empty string).Split into three helpers:
_check_api_response()— validates the HTTP status and raises descriptive errors_stream_response()— parses the SSE stream, prints tokens, collects the full response text, and manages the spinner_build_request_payload()— builds the URL, headers, and payloadThe main function is now just ~10 lines: build payload, make request, check response, stream response. Much easier to follow.
Also fixes the bug where
full_responsewas never appended to, so the function always returned an empty string.Closes #2581