Fix AllTheLyrics false positive detection#2598
Fix AllTheLyrics false positive detection#2598SayanDey322 wants to merge 1 commit intosoxoj:mainfrom
Conversation
|
Hi @SayanDey322 β I'm batching feedback for #2596, #2599, #2600, #2601, #2602, #2604 and #2605, which all follow the same one-line pattern of just flipping 1. Disabling is a last resort, not a first responseThe most valuable contribution to this project is keeping checks accurate, not pruning them. Before opening a PR that disables a site, please walk the diagnose flow described in CONTRIBUTING.md β typically: maigret --self-check --site "SiteName" --diagnose --use-disabled-sites
python utils/site_check.py --site "SiteName" --diagnose
python utils/site_check.py --site "SiteName" --compare-methodsMost "broken" sites are fixable in 2β10 minutes β switching 2. Every database edit needs to run the pre-commit hookEditing
The repo ships a pre-commit hook that does both regenerations and re-stages the result automatically β you only need to enable it once after cloning: git clone https://github.com/soxoj/maigret && cd maigret
poetry install --with dev
git config --local core.hooksPath .githooks/The hook itself lives at 3. Please redo these PRs properlyConcretely, for each of the disable PRs:
I'd much rather have one well-investigated PR that fixes 3 sites and disables 2 with explanations than seven one-liners. Please update or close-and-resubmit. Thanks for the energy you're putting in β let's redirect it into fixes π |
Summary
Fix false positives for AllTheLyrics by switching from status-code detection to message-based detection.
What changed
AllTheLyricsfromcheckType: "status_code"tocheckType: "message"Why
AllTheLyrics appears to return HTTP 200 for both valid and invalid usernames, which makes status-code detection unreliable and causes false positives.
Switching to message-based detection uses page content instead of HTTP status and prevents incorrect claimed results.
Closes #2574