SoundCloud: updated scheme and fixed test - #271
Merged
Conversation
Owner
|
@TecnoCreeper thanks a lot for contribution! I merge it 👍 |
hemant-manglani
pushed a commit
to hemant-manglani/socid-extractor
that referenced
this pull request
Aug 15, 2026
hemant-manglani
pushed a commit
to hemant-manglani/socid-extractor
that referenced
this pull request
Aug 25, 2026
hemant-manglani
pushed a commit
to hemant-manglani/socid-extractor
that referenced
this pull request
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now 3 more fields are extracted.
Also fixed respective e2e test that was failing. The test passes locally, I didn't remove the pytest skip since I assume it fails in Github Actions(?).
I run revision.py but that seems like a lot of changes, please double check it's correct.