Merge the extended plugin pack into the built-in schemes - #280
Open
soxoj wants to merge 2 commits into
Open
Conversation
88 schemes from the separate plugins repo, 263 in total. Skipped four the built-ins already do better; HuggingFace API gained the plugin's extra fields and url_mutations. Donatty read twitch.profileUrl, the API returns twitch.url.
Weburg, Kwork, Freesound and CCM ran the same search twice and called .group() on the first one. Freesound's guard checked the title while the group came from the href, so it could hit None. One _search_group helper instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra parsers lived in a separate repo and had to be dropped into
~/.socid_extractor/plugins/by hand. They're part of the package now:88 schemes, 263 in total — gaming, streaming, business cards,
competitive programming, music, investing, Mastodon and Discourse instances.
README no longer advertises the private pack, since it isn't private anymore.