Skip to content

optimize(hooks): remove obsolete disabling cache. #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

optimize(hooks): remove obsolete disabling cache. #729

merged 1 commit into from
Apr 1, 2025

Conversation

@Azir-11
Copy link
Member

@Azir-11 Azir-11 commented Mar 31, 2025

现版本的Iconify已经去除了disableCache相关内容，该方法已弃用。
相关PR：iconify/iconify#355

@Azir-11 Azir-11 requested review from Copilot April 1, 2025 03:12
Copilot AI reviewed Apr 1, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the obsolete call to disableCache from the Iconify plugin setup, in line with updates from Iconify.

  • Removed disabling cache functionality from setupIconifyOffline.

@honghuangdc honghuangdc merged commit 4e1b65b into soybeanjs:main Apr 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Azir-11 @honghuangdc