Skip to content

[Add] EmitAmbientOnUIOpenComponent EmitSoundOnUICloseComponent - #1010

Open
ArZarLordOfMango wants to merge 1 commit into
space-syndicate:masterfrom
ArZarLordOfMango:sounds
Open

[Add] EmitAmbientOnUIOpenComponent EmitSoundOnUICloseComponent#1010
ArZarLordOfMango wants to merge 1 commit into
space-syndicate:masterfrom
ArZarLordOfMango:sounds

Conversation

@ArZarLordOfMango

Copy link
Copy Markdown

Описание PR

Добавлены два компонента.
EmitAmbientOnUIOpenComponent - переключает эмбиент компач при включение выключения уишки.
EmitSoundOnUICloseComponent - делает звук когда закрывают уишку.

Почему / Баланс

гм предложил, хули нет, можно много куда добавить, например электрозвуки в лкп там или смешной музон для автоматов.

Технические детали

- type: EmitAmbientOnUIOpen 
- type: AmbientSound 
  enabled: false 
  sound: path: /Audio/_Goobstation/Ambience/SpaceWhale/leviathan-ambient.ogg 
- type: EmitSoundOnUIClose 
  sound: path: /Audio/Effects/Chemistry/bubbles.ogg

Медиа

Требования

Критические изменения

Список изменений

Comment on lines +205 to +221
private void HandleEmitAmbientOnUIOpen(EntityUid uid, EmitAmbientOnUIOpenComponent component, AfterActivatableUIOpenEvent args) {
if (_whitelistSystem.IsWhitelistFail(component.Blacklist, args.User))
{
if (TryComp<AmbientSoundComponent>(uid, out var ambient))
_ambient.SetAmbience(uid, true, ambient);
}
}

private void HandleEmitAmbientOnUIClose(EntityUid uid, EmitAmbientOnUIOpenComponent component, BoundUIClosedEvent args) {
if (TryComp<AmbientSoundComponent>(uid, out var ambient))
_ambient.SetAmbience(uid, false, ambient);
}

private void HandleEmitSoundOnUIClose(EntityUid uid, EmitSoundOnUICloseComponent component, BoundUIClosedEvent args) {
if (_whitelistSystem.IsWhitelistFail(component.Blacklist, args.Actor))
TryEmitSound(uid, component, args.Actor);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entity<T> попробуй

TryComp заменить на Resolve , чище будет

Comment on lines +57 to +59
SubscribeLocalEvent<EmitAmbientOnUIOpenComponent, AfterActivatableUIOpenEvent>(HandleEmitAmbientOnUIOpen); // CorvaxGoob
SubscribeLocalEvent<EmitAmbientOnUIOpenComponent, BoundUIClosedEvent>(HandleEmitAmbientOnUIClose); // CorvaxGoob
SubscribeLocalEvent<EmitSoundOnUICloseComponent, BoundUIClosedEvent>(HandleEmitSoundOnUIClose);// CorvaxGoob

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не легче CorvaxGoob-Start и Corvax-End поставить?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants