увеличение #306
Open
увеличение #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
блоба
Erkilana
requested review from
Tornado-Technology and
FireNameFN
as code owners
github-actions
bot
added
S: Untriaged
size/XS
S: Needs Review
github-actions
bot
added
size/M
Changes: Map
Nimfar11
reviewed
Mar 25, 2025
Content.Server/_Goobstation/GameTicking/Rules/BlobRuleSystem.cs
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
added 5 commits
March 27, 2025 01:35
FireNameFN
requested changes
Mar 27, 2025
FireNameFN
requested changes
Mar 29, 2025
FireNameFN
requested changes
Mar 30, 2025
ок Co-authored-by: FN <[email protected]>
FireNameFN
requested changes
Mar 30, 2025
| // if the user isn't the entity with the sharp component, | ||
| // they will need to be holding something with their hands, so we set needHand to true | ||
| // so that the doafter can be interrupted if they drop the item in their hands | ||
|
|
Comment on lines
-28
to
+31
|
|
||
| private const float TileBreakEnergy = 3700; | ||
| /// <summary> | ||
| /// Kinetic energy required to spawn sparks | ||
| /// </summary> | ||
| private const float SparkEnergy = 5000; | ||
| private const float SparkEnergy = 1300; |
There was a problem hiding this comment.
Разве это не ухудшение ситуации, если внимательно прочитать summary?
There was a problem hiding this comment.
Ещё бы везде // Corvax-Next-Skills-Start и так далее добавить.
FireNameFN
reviewed
Mar 30, 2025
Comment on lines
822
to
+826
| if (!ignoreCombatMode) | ||
| if (!_combatMode.IsInCombatMode(puller)) | ||
| return false; | ||
| if (!HasComp<CanChokeGrabComponent>(puller)) | ||
| return false; |
There was a problem hiding this comment.
Тут явно какая-то ошибка.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
блоба
изменен стандартный конфиг для победы блоба, также для выдачи диска с кодами