golobby for vanilla - #3715
Open
shimorio wants to merge 7 commits into
Open
Conversation
shimorio
requested review from
DIMMoon1,
JerryImMouse and
Morb0
as code owners
August 27, 2026 01:57
github-actions
Bot
added
S: Needs Review
S: Untriaged
Changes: UI
JerryImMouse
requested changes
Sep 2, 2026
JerryImMouse
left a comment
JerryImMouse
left a comment
Collaborator
There was a problem hiding this comment.
Я не уверен, что ваниле это нужно на самом деле, но ревью сделаю :P
Решать уже будет димончик
Collaborator
|
А, ещё меня смущает огромное количество изменений в коде оффов, пусть даже с комментами. Особенно private -> public в геймтикере |
Author
теперь вызывается через ивент |
JerryImMouse
reviewed
Sep 3, 2026
JerryImMouse
left a comment
JerryImMouse
left a comment
Collaborator
There was a problem hiding this comment.
Мелкие правки по комментам, во остальном lgtm
Comment on lines
+232
to
+235
| private void OnGhostJoinLobbyRequest(GhostJoinLobbyRequestEvent ev) // Corvax-GoLobby | ||
| { | ||
| PlayerJoinLobby(ev.Session); | ||
| } |
Collaborator
There was a problem hiding this comment.
Оберни в
// Corvax-Changes-Start
// Corvax-Changes-End
Comment on lines
+185
to
+197
| private void GhostGoLobby() // Corvax-GoLobby | ||
| { | ||
| if (_goLobbyConfirmWindow is { Disposed: false }) | ||
| { | ||
| _goLobbyConfirmWindow.MoveToFront(); | ||
| return; | ||
| } | ||
|
|
||
| _goLobbyConfirmWindow = new GhostGoLobbyConfirmWindow(); | ||
| _goLobbyConfirmWindow.ContinuePressed += () => _system?.GhostGoLobby(); | ||
| _goLobbyConfirmWindow.OnClose += () => _goLobbyConfirmWindow = null; | ||
| _goLobbyConfirmWindow.OpenCentered(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Оберни в
// Corvax-Changes-Start
// Corvax-Changes-End
| using Content.Shared.Ghost.Systems; | ||
| using Robust.Client.UserInterface; | ||
| using Robust.Client.UserInterface.Controllers; | ||
| using Robust.Shared.Configuration; // Corvax-GoLobby |
Collaborator
There was a problem hiding this comment.
На юзинги похуй по идее, можешь убрать отсюда коммент
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание PR
порт space-syndicate/Goob-Station#1079
Почему / Баланс
захотел
Технические детали
Для ванилы что-то да и пришлось поменять/починить.
Медиа
2026-08-27.04-42-06.mp4
Требования