Log exceptions on crash. - #297
Open
VerinSenpai wants to merge 2 commits into
Open
Conversation
Author
|
I have instead resolved to do this instead of fixing the two bugs in the linked issue is because I can't seem to make it look good ;( Also the second crash caught me off guard and its not as simple a fix as returning an authenticationfailed error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a handler for Exception to Main.
Also changes the log coming from auth url overrides to show the actual auth url. This was previously just showing the location of the variable which seemed unhelpful. Though maybe that was intended for privacy purposes? Although at that point should this even log a variable?
I have concerns this would even be deemed appropriate but I figured I'd shoot it out there and see what happens.
The throw statement that follows the log message is there to allow debuggers to pickup on the error. Also prevents the launcher
from hanging after it logs the message... for some reason?
Reason for doing this now is that I've seen a few launcher crashes which I suspect were down to domain resolution. See (#292)