Skip to content

Conversation

@stuarttimwhite
Copy link
Contributor

@stuarttimwhite stuarttimwhite commented Nov 18, 2025

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

The aliases for count on aggregation and the results for sort merge join are already available in the output_column_names field when running try_into_proof_plan, and they are not used for verification, so it is safe to remove them from the EVM plans.

What changes are included in this PR?

Removing count alias and result aliases from group by/aggregate and sort merge join, respectively.

Are these changes tested?

Yes

@stuarttimwhite stuarttimwhite marked this pull request as ready for review November 18, 2025 20:12
@stuarttimwhite stuarttimwhite changed the title refactor: drop redundant alias fields refactor!: drop redundant alias fields Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.70%. Comparing base (b0ea8a6) to head (df8c2c0).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   96.66%   96.70%   +0.03%     
==========================================
  Files         299      299              
  Lines       58060    58446     +386     
==========================================
+ Hits        56124    56518     +394     
+ Misses       1936     1928       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

This PR has been marked as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added stale and removed stale labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants