Skip to content

Conversation

@stuarttimwhite
Copy link
Contributor

@stuarttimwhite stuarttimwhite commented Dec 3, 2025

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

We unnecessarily restrict to table scans for aggregation.

What changes are included in this PR?

Remove table scan restriction in aggregate_to_proof_plan

Are these changes tested?

Yes

@stuarttimwhite stuarttimwhite marked this pull request as ready for review December 3, 2025 18:50
@stuarttimwhite stuarttimwhite changed the title Refactor/remove table scan restriction refactor: remove table scan restriction Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.70%. Comparing base (32155a9) to head (786417a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/proof-of-sql-planner/src/plan.rs 88.88% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
- Coverage   96.71%   96.70%   -0.01%     
==========================================
  Files         302      302              
  Lines       58947    58918      -29     
==========================================
- Hits        57008    56979      -29     
  Misses       1939     1939              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stuarttimwhite stuarttimwhite merged commit 3065061 into main Dec 3, 2025
16 of 18 checks passed
@stuarttimwhite stuarttimwhite deleted the refactor/remove-table-scan-restriction branch December 3, 2025 19:43
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🎉 This PR is included in version 0.127.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants