Skip to content

Conversation

@stuarttimwhite
Copy link
Contributor

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

The proof of sql contracts repo needs there to be fewer local variables in SortMergeJoinExec.

What changes are included in this PR?

Adding s struct-like object within SortMergeJoinExec to reduce local variables.

Are these changes tested?

Yes.

@stuarttimwhite stuarttimwhite marked this pull request as ready for review December 8, 2025 16:49
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.45%. Comparing base (9337aef) to head (4312e52).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   96.77%   96.45%   -0.33%     
==========================================
  Files         302      293       -9     
  Lines       59220    52149    -7071     
==========================================
- Hits        57312    50301    -7011     
+ Misses       1908     1848      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stuarttimwhite stuarttimwhite force-pushed the refactor(so)/reduce-local-variables-in-join branch from 9337aef to 4312e52 Compare December 8, 2025 18:02
@stuarttimwhite stuarttimwhite merged commit aa6b4ee into main Dec 8, 2025
15 checks passed
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

🎉 This PR is included in version 0.127.24 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@iajoiner iajoiner deleted the refactor(so)/reduce-local-variables-in-join branch January 13, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants