-
Notifications
You must be signed in to change notification settings - Fork 261
test: fix EVM proof plan deserialization test and unify test bytes #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the EVM proof plan tests to use the new FilterExec instead of the deprecated LegacyFilterExec. The key change is that FilterExec accepts a DynProofPlan as input (using TableExec), creating a nested plan structure, whereas LegacyFilterExec used a TableExpr directly.
- Updates test structure to create explicit
TableExecinstances with schema information - Updates serialization byte sequences to reflect the new variant ID (8 instead of 0) and nested plan structure
- Enhances the deserialization test with more detailed assertions using pattern matching
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a06506f to
cc09abe
Compare
cc09abe to
8dabae0
Compare
0db6a85 to
0afd463
Compare
0afd463 to
cd5aa25
Compare
cd5aa25 to
bd1b32b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bd1b32b to
16095c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
- Coverage 96.45% 96.44% -0.02%
==========================================
Files 293 290 -3
Lines 52149 51715 -434
==========================================
- Hits 50301 49875 -426
+ Misses 1848 1840 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Fix deserialization test to use empty table refs for column expressions (result columns from subplans use empty table refs per get_column_result_fields_as_references()) - Unify duplicated byte array into shared SIMPLE_FILTER_SERIALIZED_BYTES LazyLock static 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
16095c7 to
0fb82c2
Compare
|
🎉 This PR is included in version 0.127.27 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
get_column_result_fields_as_references())SIMPLE_FILTER_SERIALIZED_BYTESLazyLockstaticTest plan
cargo test -p proof-of-sql --lib evm_proof_plan::testspasses🤖 Generated with Claude Code