Skip to content

Conversation

@iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Dec 31, 2025

Summary

  • Fix deserialization test to use empty table refs for column expressions (result columns from subplans use empty table refs per get_column_result_fields_as_references())
  • Unify duplicated byte array into shared SIMPLE_FILTER_SERIALIZED_BYTES LazyLock static

Test plan

  • cargo test -p proof-of-sql --lib evm_proof_plan::tests passes

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings December 31, 2025 15:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the EVM proof plan tests to use the new FilterExec instead of the deprecated LegacyFilterExec. The key change is that FilterExec accepts a DynProofPlan as input (using TableExec), creating a nested plan structure, whereas LegacyFilterExec used a TableExpr directly.

  • Updates test structure to create explicit TableExec instances with schema information
  • Updates serialization byte sequences to reflect the new variant ID (8 instead of 0) and nested plan structure
  • Enhances the deserialization test with more detailed assertions using pattern matching

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from a06506f to cc09abe Compare December 31, 2025 15:48
@iajoiner iajoiner changed the title refactor: update EVM proof plan tests to use FilterExec instead of LegacyFilterExec test: update EVM proof plan tests to use FilterExec instead of LegacyFilterExec Dec 31, 2025
@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from cc09abe to 8dabae0 Compare December 31, 2025 15:48
@iajoiner iajoiner enabled auto-merge (squash) December 31, 2025 15:49
@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from 0db6a85 to 0afd463 Compare December 31, 2025 16:17
@iajoiner iajoiner requested a review from Copilot December 31, 2025 16:19
@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from 0afd463 to cd5aa25 Compare December 31, 2025 16:20
@iajoiner iajoiner changed the title test: update EVM proof plan tests to use FilterExec instead of LegacyFilterExec test: fix EVM proof plan deserialization test and unify test bytes Dec 31, 2025
@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from cd5aa25 to bd1b32b Compare December 31, 2025 16:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from bd1b32b to 16095c7 Compare December 31, 2025 16:33
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.44%. Comparing base (4312e52) to head (0fb82c2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   96.45%   96.44%   -0.02%     
==========================================
  Files         293      290       -3     
  Lines       52149    51715     -434     
==========================================
- Hits        50301    49875     -426     
+ Misses       1848     1840       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Fix deserialization test to use empty table refs for column expressions
  (result columns from subplans use empty table refs per
  get_column_result_fields_as_references())
- Unify duplicated byte array into shared SIMPLE_FILTER_SERIALIZED_BYTES
  LazyLock static

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@iajoiner iajoiner force-pushed the fix/filter-simple-test-bytes branch from 16095c7 to 0fb82c2 Compare January 5, 2026 18:44
@iajoiner iajoiner merged commit 7503074 into main Jan 7, 2026
16 of 17 checks passed
@iajoiner iajoiner deleted the fix/filter-simple-test-bytes branch January 7, 2026 17:23
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🎉 This PR is included in version 0.127.27 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants