feat: add various verification builder getters and setters #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 325 325
Lines 55964 55964
=======================================
Hits 53866 53866
Misses 2098 2098 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iajoiner
force-pushed
the
feat/sol/expand-verification-builder
branch
from
ed27ee3 to
49e621f
Compare
JayWhite2357
force-pushed
the
feat/sol/expand-verification-builder
branch
from
49e621f to
cbef38d
Compare
iajoiner
approved these changes
Mar 27, 2025
iajoiner
approved these changes
Mar 27, 2025
JayWhite2357
force-pushed
the
feat/sol/expand-verification-builder
branch
from
cbef38d to
357f7cf
Compare
|
🎉 This PR is included in version 0.86.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A variety of getters and setters are needed for upcoming PRs. This PR adds them all at once.
What changes are included in this PR?
The following function are added:
builder_get_first_round_mlesbuilder_get_final_round_mlesbuilder_get_aggregate_evaluationbuilder_get_column_evaluationsbuilder_set_first_round_commitmentsbuilder_get_first_round_commitmentsbuilder_set_final_round_commitmentsbuilder_get_final_round_commitmentsbuilder_set_bit_distributionsbuilder_get_chi_evaluationsbuilder_get_table_chi_evaluationsAre these changes tested?
Yes