refactor!: use fold gadget within filter gadget #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarttimwhite
force-pushed
the
feat(sol)/filter-base-helper-functions
branch
2 times, most recently
from
2771523 to
bbe2071
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
- Coverage 96.51% 96.51% -0.01%
==========================================
Files 295 295
Lines 55768 55707 -61
==========================================
- Hits 53824 53763 -61
Misses 1944 1944 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stuarttimwhite
force-pushed
the
feat(sol)/filter-base-helper-functions
branch
5 times, most recently
from
87a7e0e to
351669e
Compare
stuarttimwhite
requested review from
JayWhite2357 and
iajoiner
and removed request for
JayWhite2357
stuarttimwhite
force-pushed
the
feat(sol)/filter-base-helper-functions
branch
2 times, most recently
from
cadd64f to
92aea2b
Compare
|
This PR has been marked as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
stuarttimwhite
force-pushed
the
feat(sol)/filter-base-helper-functions
branch
from
92aea2b to
7a0bd2a
Compare
|
This PR has been marked as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
|
This PR has been marked as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.source scripts/check_commits.sh, and the commit history is certified to follow clean commit guidelines as described here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/COMMIT_GUIDELINES.mdmainhave been incorporated to this PR by simple rebase if possible, if not, then conflicts are resolved appropriately.Rationale for this change
Both filter and slice use the fold gadget logic without actually calling the fold gadget.
What changes are included in this PR?
Are these changes tested?
Yes