fix: remove deprecated answeredInRound check
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated answeredInRound checks from price feed data validation in the AssetManagement library, addressing an issue with deprecated Chainlink oracle functionality.
- Removes
roundIdandansweredInRoundvariables from price feed data retrieval - Eliminates the deprecated
answeredInRound < roundIdvalidation check - Simplifies price feed validation to only check for positive prices and valid start times
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JayWhite2357
force-pushed
the
fix/remove-answeredInRound
branch
from
56007b3 to
808b774
Compare
waelsy123
approved these changes
Sep 5, 2025
waelsy123
force-pushed
the
fix/remove-answeredInRound
branch
from
808b774 to
4098c0b
Compare
waelsy123
force-pushed
the
fix/remove-answeredInRound
branch
from
4098c0b to
f8b45de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Resolves https://github.com/PashovAuditGroup/SXT_August25_MERGED/issues/4.
What changes are included in this PR?
Removes the check, as suggested.
Are these changes tested?
They are covered by existing tests.